feat(templates): validate and warn on duplicate block definitions - #24
Merged
Conversation
Add TemplateBlockValidator to detect duplicate block definitions in theme
template overrides (e.g., multiple `{% block header %}`). Duplicate blocks
silently override, causing subtle bugs and confusing debugging.
The validator:
- Parses template files using regex to extract block names
- Warns (not errors) when duplicates are found
- Is case-insensitive (blocks are case-insensitive in Scriban)
- Integrates into TemplateEngine.GetTemplate() before parsing
This catches the issue at build time, preventing silent failures.
Includes 4 test cases covering: no duplicates, single duplicate, multiple
duplicates, and case-insensitive matching.
All 356 tests pass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TemplateBlockValidator to detect duplicate block definitions in theme template overrides (e.g., multiple
{% block header %}). Duplicate blocks silently override, causing subtle bugs and confusing debugging.The validator:
This catches the issue at build time, preventing silent failures.
Includes 4 test cases covering: no duplicates, single duplicate, multiple duplicates, and case-insensitive matching.
All 356 tests pass.
What & why
Type of change
Checklist
dotnet format Netdocs.slnx --verify-no-changespassesdotnet build Netdocs.slnx -c Releasesucceedsdotnet test Netdocs.slnx -c Releasepassesdocs-site/docs/**if behavior changedNotes for reviewers